Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for unquoted hyphenated identifiers on bigquery #1109

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

jmhain
Copy link
Contributor

@jmhain jmhain commented Jan 23, 2024

This adds support for unquoted hyphenated identifiers on bigquery, e.g. select * from foo-bar f join baz-qux b on f.id = b.id. These are only allowed in contexts where they are unambiguous, such as in a FROM or JOIN clause. (There may be other cases where they are allowed, I only tested these two.)

@coveralls
Copy link

coveralls commented Jan 23, 2024

Pull Request Test Coverage Report for Build 7632995071

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 87.626%

Totals Coverage Status
Change from base Build 7632579793: 0.03%
Covered Lines: 19254
Relevant Lines: 21973

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @jmhain -- this is wild

This adds support for unquoted hyphenated identifiers on bigquery, e.g. select * from foo-bar f join baz-qux b on f.id = b.id. These are only allowed in contexts where they are unambiguous, such as in a FROM or JOIN clause. (There may be other cases where they are allowed, I only tested these two.)

Wow the craziness of sql dialects never ceases to amaze me. Big query, why? LOL

src/parser/mod.rs Show resolved Hide resolved
tests/sqlparser_bigquery.rs Show resolved Hide resolved
@jmhain
Copy link
Contributor Author

jmhain commented Jan 23, 2024

@alamb Thanks for the prompt feedback! I pushed a couple commits incorporating your suggestions.

Wow the craziness of sql dialects never ceases to amaze me. Big query, why? LOL

lol this was my reaction as well

@alamb alamb merged commit 398a810 into apache:main Jan 24, 2024
10 checks passed
@alamb
Copy link
Contributor

alamb commented Jan 24, 2024

Thanks again @jmhain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants