-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for unquoted hyphenated identifiers on bigquery #1109
Conversation
Pull Request Test Coverage Report for Build 7632995071
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @jmhain -- this is wild
This adds support for unquoted hyphenated identifiers on bigquery, e.g. select * from foo-bar f join baz-qux b on f.id = b.id. These are only allowed in contexts where they are unambiguous, such as in a FROM or JOIN clause. (There may be other cases where they are allowed, I only tested these two.)
Wow the craziness of sql dialects never ceases to amaze me. Big query, why? LOL
@alamb Thanks for the prompt feedback! I pushed a couple commits incorporating your suggestions.
lol this was my reaction as well |
Thanks again @jmhain |
This adds support for unquoted hyphenated identifiers on bigquery, e.g.
select * from foo-bar f join baz-qux b on f.id = b.id
. These are only allowed in contexts where they are unambiguous, such as in aFROM
orJOIN
clause. (There may be other cases where they are allowed, I only tested these two.)