-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sqlparser-derive to use syn 2.0
#1040
Conversation
@serprex Some more context on this change would be useful ... I assume it is updating syn? |
Yes |
Thank you for this contribution @serprex |
Pull Request Test Coverage Report for Build 7009097570
💛 - Coveralls |
Won't have time this weekend to look into, but will look at how to run tests & fix next week (I only ran |
Thanks @serprex . Converting to a draft while review feedback is being addressed. Please mark it ready for review when it is ready for another look |
syn 2.0
syn 2.0
Given I think this may be a non trivial change, I plan to merge this immediately after #1030 Then this PR will have maximum "bake time" for early adopters and others to try it out before I release it on crates.io |
@@ -18,6 +18,6 @@ edition = "2021" | |||
proc-macro = true | |||
|
|||
[dependencies] | |||
syn = "1.0" | |||
syn = { version = "2.0", default-features = false, features = ["printing", "parsing", "derive", "proc-macro"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems according to
https://docs.rs/syn/latest/syn/index.html#optional-features
Listing these 4 will at least avoid
clone-impls (enabled by default) — Clone impls for all syntax tree types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thank you @serprex
I took the liberty of merging up from main and reducing the feature set used
Merge 0.40 + apache/datafusion-sqlparser-rs#1040 Upstream implemented END parsing as COMMIT on postgresql: apache/datafusion-sqlparser-rs#1035 allowing some convergence
https://github.com/dtolnay/syn/releases/tag/2.0.0