Support INSERT IGNORE in MySql and GenericDialect
#1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL: INSERT IGNORE INTO tasks (title, priority) VALUES ('Test Some Inserts', 1)
ERROR: sql parser error: Expected SELECT, VALUES, or a subquery in the query body, found: INTO at Line: 1, Column 15
alamb
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Thank you for the contribution @emin100 -- this PR fails a CI check
I made a PR with a proposed fix that targets this branch -- please give it a look: https://github.com/emin100/sqlparser-rs/pull/1
alamb
changed the title
INSERT IGNORE in MySql and GenericDialect
Fix for clippy + Generic Dialect
alamb
approved these changes
Oct 24, 2023
serprex
pushed a commit
to serprex/sqlparser-rs
that referenced
this pull request
Nov 6, 2023
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL: INSERT IGNORE INTO tasks (title, priority) VALUES ('Test Some Inserts', 1)
ERROR: sql parser error: Expected SELECT, VALUES, or a subquery in the query body, found: INTO at Line: 1, Column 15