Pyo3 refactorings #740
Merged
Pyo3 refactorings #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gister_object_store
When available, using an already bound python token is zero-cost. Python::with_gil carries a runtime check. Ref: PyO3/pyo3#4274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #727.
Rationale for this change
pyo3 recommend using the Python token from a
Bound<'_, T>type or automatically passed in as a method parameter for a#[pymethods]or#[pyfunction]because they are zero-cost.Python::with_gilcarries a runtime check overhead.What changes are included in this PR?
I changed all the places that had straightforward removal of
Python::with_gil.Additionally, I removed some manual type conversion work by letting pyo3 do it automatically as we cross the python-rust boundary.
Are there any user-facing changes?
No