-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read_json
to SessionContext
#56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @larskarg
@larskarg It looks like there is a Python lint issue and also needs an upmerge |
Upmerge done. I did also run
locally but didn't see any Python lint issues. Unfortunately, I cannot trigger the github workflow as a first-time contributor. Can you please point me to the Python lint issue? Thanks. |
🎉 |
Related to #28.
MR adds functionality to read json files. I have added some tests cases (not all parameters are covered). Please let me know if the test cases are sufficient and/or if I should store the test data differently.
Example: