Add Python wrapper for LogicalPlan::Limit #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
viirya
reviewed
Feb 19, 2023
viirya
approved these changes
Feb 19, 2023
viirya
reviewed
Feb 19, 2023
viirya
reviewed
Feb 19, 2023
src/expr/limit.rs
Outdated
|
|
||
| // Retrieves the input `LogicalPlan` to this `Limit` node | ||
| fn input(&self) -> PyResult<PyLogicalPlan> { | ||
| // DataFusion make a loose guarantee that each Limit should have an input, however |
There was a problem hiding this comment.
Hmm, is Limit different to other op e.g., Sort? I.e., #196, it is simply PyLogicalPlan::from((*self.sort.input).clone()).
There was a problem hiding this comment.
Yes, I based this one on projection. I have now simplified both as part of this PR. Thanks for catching this.
Co-authored-by: Liang-Chi Hsieh <[email protected]>
andygrove
added a commit
that referenced
this pull request
Feb 22, 2023
* changelog (#188) * Add Python wrapper for LogicalPlan::Sort (#196) * Add Python wrapper for LogicalPlan::Aggregate (#195) * Add Python wrapper for LogicalPlan::Limit (#193) * Add Python wrapper for LogicalPlan::Filter (#192) * Add Python wrapper for LogicalPlan::Filter * clippy * clippy * Update src/expr/filter.rs Co-authored-by: Liang-Chi Hsieh <[email protected]> --------- Co-authored-by: Liang-Chi Hsieh <[email protected]> * Add tests for recently added functionality (#199) * Add experimental support for executing SQL with Polars and Pandas (#190) * Run `maturin develop` instead of `cargo build` in verification script (#200) * Implement `to_pandas()` (#197) * Implement to_pandas() * Update documentation * Write unit test * Add support for cudf as a physical execution engine (#205) * Update README in preparation for 0.8 release (#206) * Analyze table bindings (#204) * method for getting the internal LogicalPlan instance * Add explain plan method * Add bindings for analyze table * Add to_variant * cargo fmt * blake and flake formatting * changelog (#209) --------- Co-authored-by: Liang-Chi Hsieh <[email protected]> Co-authored-by: Dejan Simic <[email protected]> Co-authored-by: Jeremy Dyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #191
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?