chore: remove XFAIL from passing tests (#884)

* remove xfail from passing tests * update xfail cmoment for datetime_s * document upstream issue for timestamp[s] xfail test
apache · Sep 28, 2024 · 2df33d3 · 2df33d3
1 parent 8b36aac
commit 2df33d3
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/python/datafusion/tests/test_sql.py b/python/datafusion/tests/test_sql.py
@@ -378,23 +378,29 @@ def test_udf(
         helpers.data_binary_other(),
         helpers.data_date32(),
         helpers.data_with_nans(),
-        # C data interface missing
         pytest.param(
             pa.array([b"1111", b"2222", b"3333"], pa.binary(4), _null_mask),
             id="binary4",
-            marks=pytest.mark.xfail,
         ),
+        # `timestamp[s]` does not roundtrip for pyarrow.parquet: https://github.com/apache/arrow/issues/41382
         pytest.param(
-            helpers.data_datetime("s"), id="datetime_s", marks=pytest.mark.xfail
+            helpers.data_datetime("s"),
+            id="datetime_s",
+            marks=pytest.mark.xfail(
+                reason="pyarrow.parquet does not support timestamp[s] roundtrips"
+            ),
         ),
         pytest.param(
-            helpers.data_datetime("ms"), id="datetime_ms", marks=pytest.mark.xfail
+            helpers.data_datetime("ms"),
+            id="datetime_ms",
         ),
         pytest.param(
-            helpers.data_datetime("us"), id="datetime_us", marks=pytest.mark.xfail
+            helpers.data_datetime("us"),
+            id="datetime_us",
         ),
         pytest.param(
-            helpers.data_datetime("ns"), id="datetime_ns", marks=pytest.mark.xfail
+            helpers.data_datetime("ns"),
+            id="datetime_ns",
         ),
         # Not writtable to parquet
         pytest.param(