-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change maven group ID to org.apache.datafusion
#941
Conversation
@huaxingao This will presumably affect the dependency in iceberg that we are proposing to add. |
@andygrove the previous discussion on this is still relevant (I don't have a strong opinion on this). |
I had a brief discussion with ASF infra and they said that the Maven group ID should be |
Well, that settles it then. |
Infra also mentioned that we should perform a Podling name search at some point to check whether Comet is allowable as a TLP. Comet components are already in other Apache projects (Apache Tomcat and Apache Tuscany). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@parthchandra Do I need to change anything on iceberg side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The dependency will change from |
Which issue does this PR close?
Part of #721
Rationale for this change
I am requesting that ASF INFRA sets up Nexus access for the DataFusion project so that we can publish Maven artifacts. The normal convention for maven group ids for Apache projects is
org.apache.TLPNAME
, so I think we need to revisit changing our Maven group ids ( in the pom.xml) fromorg.apache.comet
toorg.apache.datafusion
. The DataFusion project could hypothetically want to publish Java bindings to Maven in the future as well. The artifact names would not change and there is no need to change package names in the code.Note that we did previously discuss this back in #278.
What changes are included in this PR?
How are these changes tested?