Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change maven group ID to org.apache.datafusion #941

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Sep 12, 2024

Which issue does this PR close?

Part of #721

Rationale for this change

I am requesting that ASF INFRA sets up Nexus access for the DataFusion project so that we can publish Maven artifacts. The normal convention for maven group ids for Apache projects is org.apache.TLPNAME, so I think we need to revisit changing our Maven group ids ( in the pom.xml) from org.apache.comet to org.apache.datafusion. The DataFusion project could hypothetically want to publish Java bindings to Maven in the future as well. The artifact names would not change and there is no need to change package names in the code.

Note that we did previously discuss this back in #278.

What changes are included in this PR?

How are these changes tested?

@parthchandra
Copy link
Contributor

@huaxingao This will presumably affect the dependency in iceberg that we are proposing to add.

@parthchandra
Copy link
Contributor

@andygrove the previous discussion on this is still relevant (I don't have a strong opinion on this).
is it still possible for the DataFusion project to publish to multiple maven group ids or does the Nexus repository setup only allow a single group id per project.

@andygrove
Copy link
Member Author

@andygrove the previous discussion on this is still relevant (I don't have a strong opinion on this). is it still possible for the DataFusion project to publish to multiple maven group ids or does the Nexus repository setup only allow a single group id per project.

I had a brief discussion with ASF infra and they said that the Maven group ID should be org.apache.TLPNAME although there are exceptions to that. If we want to use a different TLPNAME then I think we will need to have a conversation with ASF infra to request an exception.

@parthchandra
Copy link
Contributor

I had a brief discussion with ASF infra and they said that the Maven group ID should be org.apache.TLPNAME

Well, that settles it then.

@andygrove
Copy link
Member Author

Infra also mentioned that we should perform a Podling name search at some point to check whether Comet is allowable as a TLP. Comet components are already in other Apache projects (Apache Tomcat and Apache Tuscany).

https://incubator.apache.org/guides/names.html

@andygrove andygrove added this to the 0.3.0 milestone Sep 16, 2024
Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huaxingao
Copy link
Contributor

This will presumably affect the dependency in iceberg that we are proposing to add.

@parthchandra Do I need to change anything on iceberg side?

Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthchandra
Copy link
Contributor

This will presumably affect the dependency in iceberg that we are proposing to add.

@parthchandra Do I need to change anything on iceberg side?

The dependency will change from org.apache.comet:comet-spark to org.apache.datafusion:comet-spark etc

@andygrove andygrove merged commit acd5aac into apache:main Sep 16, 2024
77 checks passed
@andygrove andygrove deleted the change-maven-group-id2 branch September 16, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants