chore: Add config for enabling SMJ with join condition #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, related to apache/datafusion#9846 |
comphead
reviewed
Sep 11, 2024
comphead
reviewed
Sep 11, 2024
Co-authored-by: Oleks V <[email protected]>
Co-authored-by: Oleks V <[email protected]>
viirya
approved these changes
Sep 11, 2024
| @@ -262,6 +262,7 @@ trait CometPlanStabilitySuite extends DisableAdaptiveExecutionSuite with TPCDSBa | |||
| CometConf.COMET_EXEC_ENABLED.key -> "true", | |||
| CometConf.COMET_DPP_FALLBACK_ENABLED.key -> "false", | |||
| CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true", | |||
| CometConf.COMET_EXEC_SORT_MERGE_JOIN_WITH_JOIN_FILTER_ENABLED.key -> "true", | |||
There was a problem hiding this comment.
@andygrove Do you remember by any chance why COMET_EXEC_SORT_MERGE_JOIN_WITH_JOIN_FILTER_ENABLED is enabled only for testQuery() but not for createSparkSession()?
There was a problem hiding this comment.
Maybe this one? #901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #901
Rationale for this change
There are known correctness and performance issues with our support for SMJ with join condtion, so we should disable it by default.
What changes are included in this PR?
New config.
How are these changes tested?