fix: Mark cast from float/double to decimal as incompatible #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the following test failure: |
andygrove
commented
Feb 7, 2025
Comment on lines
-873
to
+892
| val table = "t1" | ||
| val table = s"final_decimal_avg_$dictionaryEnabled" |
There was a problem hiding this comment.
These changes ended up not being entirely necessary, but the test did have a mix of hard-coded t1 and use of the variable $tableName references in SQL, and I made these consistent.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1372 +/- ##
=============================================
- Coverage 56.12% 39.17% -16.96%
- Complexity 976 2065 +1089
=============================================
Files 119 262 +143
Lines 11743 60327 +48584
Branches 2251 12836 +10585
=============================================
+ Hits 6591 23631 +17040
- Misses 4012 32223 +28211
- Partials 1140 4473 +3333 ☔ View full report in Codecov by Sentry. |
kazuyukitanimura
approved these changes
Feb 7, 2025
| withTable(tableName) { | ||
| val table = spark.read.parquet(filename).coalesce(1) | ||
| table.createOrReplaceTempView(tableName) | ||
| checkSparkAnswer(s"SELECT c1, avg(c7) FROM $tableName GROUP BY c1 ORDER BY c1") |
There was a problem hiding this comment.
Would you mind adding // https://github.com/apache/datafusion-comet/issues/1371 and mention to use checkSparkAnswerAndNumOfAggregates once resolved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1354
Follow on issue: #1371
Rationale for this change
Fix a correctness issue
What changes are included in this PR?
How are these changes tested?
New test + existing tests