Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ExecutionGraph encoding and decoding logic into execution_graph for better encapsulation #150

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

yahoNanJing
Copy link
Contributor

Which issue does this PR close?

Closes #149.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@yahoNanJing
Copy link
Contributor Author

Hi @andygrove and @thinkharderdev, could you help review this PR?

@yahoNanJing yahoNanJing mentioned this pull request Aug 17, 2022
18 tasks
@andygrove
Copy link
Member

@thinkharderdev @avantgardnerio @mingmwang any objections to me merging this one?

Copy link
Contributor

@thinkharderdev thinkharderdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove merged commit 914dba6 into apache:master Aug 22, 2022
@avantgardnerio
Copy link
Contributor

Sorry I'm late to the party, but 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better encapsulation for ExecutionGraph
5 participants