chore: dependency cleanup #1150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as users can create their own scheduler/executor binaries we should make optional dependencies which are needed to for scheduler/executor binaries
tbar4
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Can you help me understand why we are removing the tracing? I know you have a good reason, just I am missing the context.
There was a problem hiding this comment.
we use tracing we use log, we need to pick one and stick with it. log is use across project, so i remove those few statements which used tracing
There was a problem hiding this comment.
whole point of this PR is to decrease number of dependencies used in core components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes none.
Rationale for this change
There are a bit too many dependencies, some of which are duplicated and can be replaced with some other we use, some of which are not maintained. As users can create their own binaries there is no need to depend on dependencies which our binaries use.
There were cases where log and trace has been used in the same files, I have removed trace but we can revisit that decision in subsequent PRs
What changes are included in this PR?
Are there any user-facing changes?
No