Skip to content

Commit

Permalink
Disable the ansi feature of tracing-subscriber
Browse files Browse the repository at this point in the history
  • Loading branch information
kyotoYaho committed May 26, 2023
1 parent d56d4b9 commit ea37030
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 18 deletions.
3 changes: 3 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ object_store = "0.5.6"
sqlparser = "0.33.0"
tonic = { version = "0.9" }
tonic-build = { version = "0.9", default-features = false, features = ["transport", "prost"] }
tracing = "0.1.36"
tracing-appender = "0.2.2"
tracing-subscriber = { version = "0.3.15", features = ["env-filter"] }

# cargo build --profile release-lto
[profile.release-lto]
Expand Down
10 changes: 3 additions & 7 deletions ballista/executor/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,9 @@ tokio = { version = "1.0", features = [
] }
tokio-stream = { version = "0.1", features = ["net"] }
tonic = { workspace = true }
tracing = "0.1.36"
tracing-appender = "0.2.2"
tracing-subscriber = { version = "0.3.15", features = [
"fmt",
"env-filter",
"ansi",
] }
tracing = { workspace = true }
tracing-appender = { workspace = true }
tracing-subscriber = { workspace = true }
uuid = { version = "1.0", features = ["v4"] }

[dev-dependencies]
Expand Down
4 changes: 2 additions & 2 deletions ballista/executor/src/executor_process.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ pub async fn start_executor_process(opt: ExecutorProcessConfig) -> Result<()> {
}
};
tracing_subscriber::fmt()
.with_ansi(true)
.with_ansi(false)
.with_thread_names(opt.print_thread_info)
.with_thread_ids(opt.print_thread_info)
.with_writer(log_file)
Expand All @@ -117,7 +117,7 @@ pub async fn start_executor_process(opt: ExecutorProcessConfig) -> Result<()> {
} else {
// Console layer
tracing_subscriber::fmt()
.with_ansi(true)
.with_ansi(false)
.with_thread_names(opt.print_thread_info)
.with_thread_ids(opt.print_thread_info)
.with_writer(io::stdout)
Expand Down
10 changes: 3 additions & 7 deletions ballista/scheduler/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,9 @@ tokio = { version = "1.0", features = ["full"] }
tokio-stream = { version = "0.1", features = ["net"], optional = true }
tonic = { workspace = true }
tower = { version = "0.4" }
tracing = "0.1.36"
tracing-appender = "0.2.2"
tracing-subscriber = { version = "0.3.15", features = [
"fmt",
"env-filter",
"ansi",
] }
tracing = { workspace = true }
tracing-appender = { workspace = true }
tracing-subscriber = { workspace = true }
uuid = { version = "1.0", features = ["v4"] }
warp = "0.3"

Expand Down
4 changes: 2 additions & 2 deletions ballista/scheduler/src/bin/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ async fn main() -> Result<()> {
}
};
tracing_subscriber::fmt()
.with_ansi(true)
.with_ansi(false)
.with_thread_names(print_thread_info)
.with_thread_ids(print_thread_info)
.with_writer(log_file)
Expand All @@ -92,7 +92,7 @@ async fn main() -> Result<()> {
} else {
// Console layer
tracing_subscriber::fmt()
.with_ansi(true)
.with_ansi(false)
.with_thread_names(print_thread_info)
.with_thread_ids(print_thread_info)
.with_writer(io::stdout)
Expand Down

0 comments on commit ea37030

Please sign in to comment.