Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Ωedit™ v0.9.76 #902

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

scholarsmate
Copy link
Contributor

@scholarsmate scholarsmate commented Nov 22, 2023

Upgrade to Ωedit™ v0.9.76. This upgrade contains Windows fixes.

Closes #903.

@scholarsmate scholarsmate added dependencies Pull requests that update a dependency file data editor Issues related to the Data Editor capability labels Nov 22, 2023
@scholarsmate scholarsmate added this to the 1.4.0 milestone Nov 22, 2023
@scholarsmate scholarsmate self-assigned this Nov 22, 2023
@scholarsmate scholarsmate linked an issue Nov 22, 2023 that may be closed by this pull request
@lrbarber
Copy link
Collaborator

The Windows builds are failing CI with java.lang.RuntimeException: Non zero return code from xjc

@shanedell
Copy link
Contributor

@scholarsmate Can you rebase this PR on main and see if it fixes the CI?

@shanedell
Copy link
Contributor

@scholarsmate So the issue that is causing your CI to fail is due to an issue that should be fixed in main. Are you sure this branch is fully in sync with main? I don't think it is because it should actually have more CI stages than what it has currently, meaning it should have stages for different Java versions. So try rebasing off the latest of the Apache main branch and this should be good to go 👍

@scholarsmate
Copy link
Contributor Author

Rebased on main as suggested.

Copy link
Contributor

@shanedell shanedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 👍

Copy link
Collaborator

@stricklandrbls stricklandrbls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

rthomas320
rthomas320 previously approved these changes Dec 5, 2023
Copy link
Collaborator

@rthomas320 rthomas320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the PR to my PC and compiled and ran it. The first two files I opened omega edit seemed to work properly. The grpc window closed when I closed the editor in vscode. However when I opened a 3rd file I got failed to create session and failed to create viewport errors. And the grpc window failed to close when I closed the editor. I attached the log file.
dataEditor-9000.log

@rthomas320 rthomas320 dismissed their stale review December 5, 2023 17:55

It should have been a comment

@scholarsmate
Copy link
Contributor Author

@rthomas320, well that's come a long way. It opens, closes, and we have now have informative logs. The logs are stating that the client cannot connect to 127.0.0.1 on port 9000. I'm going to merge this in as it is an improvement, then we can drill down farther on the connection refused issue more in a different ticket/PR.

@scholarsmate scholarsmate merged commit 8e682aa into apache:main Dec 5, 2023
21 checks passed
@scholarsmate scholarsmate deleted the omega-edit-v0.9.76 branch December 5, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data editor Issues related to the Data Editor capability dependencies Pull requests that update a dependency file
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade to Ωedit™ v0.9.76
5 participants