Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small files causing boundary issues in the Data Editor #819

Closed
scholarsmate opened this issue Aug 17, 2023 · 0 comments · Fixed by #820
Closed

Small files causing boundary issues in the Data Editor #819

scholarsmate opened this issue Aug 17, 2023 · 0 comments · Fixed by #820
Assignees
@stricklandrbls
Labels
bug Something isn't working data editor Issues related to the Data Editor capability typescript
Milestone
1.3.1

Comments

@scholarsmate
Copy link
Contributor

Scrolling around in a small file caused the following to happen in the UI:

Screenshot 2023-08-17 at 11 13 56 AM

Logs indicate that a negative offset is being sent to the Ωedit server:

{"level":"DEBUG","time":"2023-08-17T15:42:51.338Z","pid":86239,"hostname":"evc-1901021","fn":"modifyViewport","rqst":{"viewportId":"L1VzZXJzL3NoZWFyZXJkL0RvY3VtZW50cy9HaXRIdWIvZGFmZm9kaWwtdnNjb2RlLWN0Yy1vc3MvTk9USUNF:caace1e9-95cf-4f3e-ba84-f8c03f8f47c2","offset":-656,"capacity":1024,"isFloating":false}}
@scholarsmate scholarsmate added bug Something isn't working typescript data editor Issues related to the Data Editor capability labels Aug 17, 2023
@scholarsmate scholarsmate added this to the 1.3.1 milestone Aug 17, 2023
@scholarsmate scholarsmate moved this to In Progress in daffodil-vscode-v1.3.1 Aug 17, 2023
stricklandrbls added a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 17, 2023
@stricklandrbls
Fix File/Viewport Navigation Issue
5beada5 
- Fix issue where file/viewport navigation would send invalid offsets to
  omega edit if the filesize was smaller than the viewport capacity.
- Reworked portions of the `getLogger` functionality.

Closes apache#819
stricklandrbls pushed a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 17, 2023
@scholarsmate @stricklandrbls
Fix File/Viewport Navigation Issue
13edc13 
- Fixes issue where the UI would send viewport data requests w/ invalid
  offsets if the filesize was less than the viewport capacity.
- Reworked `getLogger` functionality of data editor extension.

Closes apache#819
@stricklandrbls stricklandrbls mentioned this issue Aug 17, 2023
Merged
stricklandrbls pushed a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 17, 2023
@scholarsmate @stricklandrbls
Fix File/Viewport Navigation Issue
af60e3b 
- Fixes issue where the UI would send viewport data requests w/ invalid
  offsets if the filesize was less than the viewport capacity.
- Reworked `getLogger` functionality of data editor extension.

Closes apache#819
stricklandrbls pushed a commit that referenced this issue Aug 18, 2023
@scholarsmate @stricklandrbls
Fix File/Viewport Navigation Issue
25d9f1f 
- Fixes issue where the UI would send viewport data requests w/ invalid
  offsets if the filesize was less than the viewport capacity.
- Reworked `getLogger` functionality of data editor extension.

Closes #819
@github-project-automation github-project-automation bot moved this from In Progress to Done in daffodil-vscode-v1.3.1 Aug 18, 2023
stricklandrbls pushed a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 18, 2023
@scholarsmate @stricklandrbls
Fix File/Viewport Navigation Issue
d8b4e0a 
- Fixes issue where the UI would send viewport data requests w/ invalid
  offsets if the filesize was less than the viewport capacity.
- Reworked `getLogger` functionality of data editor extension.

Closes apache#819
stricklandrbls pushed a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 18, 2023
@scholarsmate @stricklandrbls
Fix File/Viewport Navigation Issue
4b350a9 
- Fixes issue where the UI would send viewport data requests w/ invalid
  offsets if the filesize was less than the viewport capacity.
- Reworked `getLogger` functionality of data editor extension.

Closes apache#819
stricklandrbls pushed a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 18, 2023
@scholarsmate @stricklandrbls
Fix File/Viewport Navigation Issue
7e2ce08 
- Fixes issue where the UI would send viewport data requests w/ invalid
  offsets if the filesize was less than the viewport capacity.
- Reworked `getLogger` functionality of data editor extension.

Closes apache#819
stricklandrbls pushed a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 18, 2023
@scholarsmate @stricklandrbls
Fix File/Viewport Navigation Issue
5b909a2 
- Fixes issue where the UI would send viewport data requests w/ invalid
  offsets if the filesize was less than the viewport capacity.
- Reworked `getLogger` functionality of data editor extension.

Closes apache#819
stricklandrbls pushed a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 18, 2023
@scholarsmate @stricklandrbls
Fix File/Viewport Navigation Issue
79df429 
- Fixes issue where the UI would send viewport data requests w/ invalid
  offsets if the filesize was less than the viewport capacity.
- Reworked `getLogger` functionality of data editor extension.

Closes apache#819
stricklandrbls pushed a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 21, 2023
@scholarsmate @stricklandrbls
Fix File/Viewport Navigation Issue
645ebfb 
- Fixes issue where the UI would send viewport data requests w/ invalid
  offsets if the filesize was less than the viewport capacity.
- Reworked `getLogger` functionality of data editor extension.

Closes apache#819
stricklandrbls pushed a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 21, 2023
@scholarsmate @stricklandrbls
Fix File/Viewport Navigation Issue
05689f6 
- Fixes issue where the UI would send viewport data requests w/ invalid
  offsets if the filesize was less than the viewport capacity.
- Reworked `getLogger` functionality of data editor extension.

Closes apache#819
@stricklandrbls stricklandrbls mentioned this issue Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stricklandrbls stricklandrbls

Labels
bug Something isn't working data editor Issues related to the Data Editor capability typescript
Projects
No open projects
daffodil-vscode-v1.3.1
Status: Done
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

Fix File/Viewport Navigation Issue ctc-oss/daffodil-vscode
2 participants
@scholarsmate @stricklandrbls