-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CURATOR-502] Update guava-version to 27.0.1 #302
Conversation
This doesn't compile for me - I get a ton of errors. Also, please rename the PR so that to something like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it 27.0.1-jre?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is the wrong version
@Randgalt as guava has a lot of issues about forward/backward compatibility, did you ever consider to shade it and relocate packages? |
It already is shaded. see here: https://github.com/apache/curator/blob/master/curator-client/pom.xml#L90 |
Ops. Sorry. |
TBH - this PR is not needed. But, we keep getting requests for it so I'm OK with making the change. But, it's not trivial. Several parts of the codebase need to be updated. |
Also see here: https://cwiki.apache.org/confluence/display/CURATOR/TN13 |
@Randgalt thanks for the pointer. |
Not at this time. It would be pretty disruptive and there hasn't been a call for it. But, if someone proposes something it will definitely be considered. |
This can be closed in favor of #301 |
Sure, everything that's update the version is ok for me. |
No description provided.