Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: replace existing services with GitHub Actions #29

Merged
merged 5 commits into from
Apr 1, 2020
Merged

ci: replace existing services with GitHub Actions #29

merged 5 commits into from
Apr 1, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 1, 2020

Motivation, Context & Description

  • Use GitHub Actions Workflow
  • Added nyc code coverage to match other repo GitHub Actions Workflow
  • Drop Travis CI
  • Drop AppVeyor
  • Commit package-lock.json to use npm cit
  • Add GitHub Actions Workflow status badge to README

Testing

  • npm t
  • Review GitHub Actions Test Run

Checklist

  • I've run the tests to see all new and existing tests pass
  • I've updated the documentation if necessary

@erisu erisu added this to the 4.0.0 milestone Apr 1, 2020
@erisu erisu requested a review from timbru31 April 1, 2020 07:44
@timbru31
Copy link
Member

timbru31 commented Apr 1, 2020

Ref to apache/cordova#4

@janpio janpio mentioned this pull request Apr 1, 2020
Open
39 tasks
@timbru31
Copy link
Member

timbru31 commented Apr 1, 2020

I assume you need to rebuild the lockfile since #28 was merged :)

@erisu
Copy link
Member Author

erisu commented Apr 1, 2020

Not until #27 is merged.

@erisu erisu force-pushed the ci/use-github-actions branch from b8278bc to 33b87f5 Compare April 1, 2020 08:06
@erisu
Copy link
Member Author

erisu commented Apr 1, 2020

rebased and ready for review.

@erisu erisu merged commit 3e8ec0d into apache:master Apr 1, 2020
@erisu erisu deleted the ci/use-github-actions branch April 1, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbru31 timbru31 timbru31 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @timbru31