Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: vibration tests to reduce redundancy and improve readability #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Viole07
Copy link

@Viole07 Viole07 commented Oct 26, 2024

Platforms affected

JavaScript (test.js)

Motivation and Context

This refactoring improves the readability and maintainability of the vibration test code by consolidating repetitive functions and reducing redundancy.

Description

  • Refactored code to streamline vibration test functions and minimize duplication.
  • Reorganized HTML generation and action button creation to improve clarity.
  • Simplified the cancellation logic and optimized timeout handling.

Testing

Manually verified vibration functionality across tests, ensuring both initiation and cancellation work as expected for all supported patterns.

Checklist

  • I've run the tests to ensure all new and existing tests pass.
  • I added automated test coverage where applicable.
  • Commit is prefixed with (js) as this change affects all JavaScript platforms supporting vibration.
  • If this Pull Request resolves an issue, I linked to the issue in the text above.
  • I've updated the documentation if necessary.

@Viole07 Viole07 changed the title refactor/ vibration tests to reduce redundancy and improve readability refactor: vibration tests to reduce redundancy and improve readability Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants