-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android, ios): use clobbers to overwrite screen.orientation #116
Conversation
I can confirm that this patch works in my ionic5 and Angular12 app for iOS 16.4, 16.1, 15.1 and Android 11, 12 y 13 tested in real devices. |
This mostly works but I've noticed two issues:
|
Updating capacitor to 4.8.0 resolved the issues above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Wondering when this will be merge completed? |
Also wondering when this merge will be completed. We would love to use this! |
Same here, really need this fix ! |
This comment was marked as abuse.
This comment was marked as abuse.
any plans to release this fix? |
please release this fix |
Any chance we can push this forward? |
What is the reason for not releasing this fix? |
Looks like tests for iOS 13 and 14 are failing. Are there any updates on getting this fix published? |
I had a very short look in the details but didn't get the failure. |
Logs have expired now. So what's happening? |
This comment was marked as abuse.
This comment was marked as abuse.
Are there any releases planned with this fix? |
I am also having the same issue, any ETA on this? |
who are all having this issue, please follow
this will update the plugin into latest code, and now orientation is working fine |
For some reason the
screen.orientation
overwrite done from the current javascript code is not working properly in iOS 16.4 and newer.Using the
clobbers
tag in plugin.xml seems to fix the issue and the plugin keeps working on previous iOS versions and on Android.closes #114
closes #35