Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13632: (android) Allow UDP media streaming. #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

goffioul
Copy link

@goffioul goffioul commented Dec 4, 2017

Platforms affected

Android.

What does this PR do?

Handle UDP media URL as streaming.

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@janpio
Copy link
Member

janpio commented Oct 1, 2018

Hey, I just fixed the problem that caused Android tests to fail in master. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR.

@erisu
Copy link
Member

erisu commented Aug 31, 2022

Sorry that this PR was left open for quite a long time. I didn’t even start working on Cordova till about a year after this PR was created.

Anyways, I have been going through older PRs and trying to find out what could be still relevant, what I understand, and that maybe I could merge.

With regards to this PR, allowing UDP is acceptable but IMO, but I would like to refactor this area a step further for the next major release.

Ideally to improve flexibility and security.

My idea would be that a config preference would be created to allow users to provide the acceptable URL prefixes.

For example:

<preference name=“MEDIA_STREAMING_ALLOWED_PREFIX” value=“https://,http://” />

With the above preference, UDP or anything else in the future could be added without a new PR.

Also, the developer could even take their security a step further by providing a more exact URL prefix instead of just schemes.

e.g.

<preference name=“MEDIA_STREAMING_ALLOWED_PREFIX” value=“https://cordova.apache.org/” />

Technically this PR could be merged in as is, but if we do create a config preference in the future for a later major release, the UDP scheme would stop working again as the idea of the plugin is to not accept or open any URL by default.

What do you think about this?
Do you think it’s something you want to do?

@goffioul
Copy link
Author

If you're planning to refactor how the streaming URLs are determined (personally, I don't have time to dedicate to that), then I don't think it makes sense to merge this PR. I've been using my own fork for almost 5yrs, there's no rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants