Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): Fix app halt when an audio ends w/ another playing #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liruqi
Copy link

@liruqi liruqi commented Jul 21, 2016

Platforms affected

iOS 9

What does this PR do?

Fix app halt when an audio ends with another playing

What testing has been done on this change?

My T-Rex runner for iOS based on https://github.com/riccardo-forina/chromium-dyno-crossbrowser

Checklist

  • ICLA has been signed and submitted to [email protected].
  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Link Link Link

@janpio
Copy link
Member

janpio commented Aug 18, 2018

Hey @liruqi, can you explain what exact behavior this changes? How was it before, how is it now?
Also, there seems to be a conflict now - could you take a look and maybe resolve it? Thanks.

@janpio janpio added the bug label Sep 17, 2018
@janpio janpio changed the title Fix app halt when an audio ends w/ another playing fix(ios): Fix app halt when an audio ends w/ another playing Jul 3, 2019
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard merge conflict, unclear reason for PR. Have to look deeper before being able to decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants