Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing information for iOS #181

Merged
merged 7 commits into from
Mar 30, 2020
Merged

Add missing information for iOS #181

merged 7 commits into from
Mar 30, 2020

Conversation

mosabab
Copy link
Contributor

@mosabab mosabab commented Nov 4, 2019

closes #149

Platforms affected

IOS

Motivation and Context

Add missing information regarding this plugin for ios geolocation requirements.

Description

Add missing information, by describes the reason that the app accesses the user's location in different situations.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@mosabab mosabab changed the title Update README.md Update README.md [missing info] Nov 4, 2019
@mosabab mosabab changed the title Update README.md [missing info] Add missing information [IOS] Nov 7, 2019
@mosabab
Copy link
Contributor Author

mosabab commented Nov 14, 2019

Hello @breautek , I also update this documents with missing information, please review it. Thanks

Copy link
Contributor Author

@mosabab mosabab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update readme

mosabab and others added 2 commits November 15, 2019 20:25
Co-Authored-By: Norman Breau <[email protected]>
Co-Authored-By: Norman Breau <[email protected]>
@mosabab
Copy link
Contributor Author

mosabab commented Nov 15, 2019

Please review it

Co-Authored-By: Norman Breau <[email protected]>
@mosabab
Copy link
Contributor Author

mosabab commented Nov 15, 2019

Please review it now and check if everything is ok

@mosabab mosabab changed the title Add missing information [IOS] Add missing information [iOS] Nov 17, 2019
@mosabab mosabab changed the title Add missing information [iOS] Add missing information for iOS Nov 19, 2019
Co-Authored-By: Norman Breau <[email protected]>
@breautek breautek merged commit 4d14db2 into apache:master Mar 30, 2020
@patrizi
Copy link

patrizi commented Aug 10, 2021

Hi,
I report that the problem is back.

This is what Apple write me:

ITMS-90683: Missing Purpose String in Info.plist- Your app's code references one or more APIs that access sensitive user data. The app's Info.plist file should contain a NSLocationAlwaysUsageDescription key with a user-facing purpose string explaining clearly and completely why your app needs the data. Starting Spring 2019, all apps submitted to the App Store that access user data are required to include a purpose string. If you're using external libraries or SDKs, they may reference APIs that require a purpose string. While your app might not use these APIs, a purpose string is still required. You can contact the developer of the library or SDK and request they release a version of their code that doesn't contain the APIs. Learn more (https://developer.apple.com/documentation/uikit/core_app/protecting_the_user_s_privacy).

My configuration is:
platform ios 5.1.1
cordova-plugin-geolocation 4.0.2 "Geolocation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for gelocation plugin should be updated to meet new apple rules about location access
4 participants