feat: bump plugin version for next major #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breautek
approved these changes
Jul 23, 2021
jcesarmobile
requested changes
Aug 3, 2021
package.json
Outdated
| "cordova-android": "<10.0.0", | ||
| "cordova-ios": ">=5.1.0", | ||
| "cordova": ">=9.0.0" | ||
| }, | ||
| "6.0.0": { |
There was a problem hiding this comment.
6.0.0 should include new engines and the >100 should be for a 7.0.0 entry
plugin.xml
Outdated
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| <engines> | |||
| <engine name="cordova" version=">=9.0.0"/> | |||
| <engine name="cordova-android" version=">=9.0.0" /> | |||
| <engine name="cordova-android" version="<10.0.0" /> | |||
There was a problem hiding this comment.
Should be
Suggested change
| <engine name="cordova-android" version="<10.0.0" /> | |
| <engine name="cordova-android" version=">=10.0.0" /> |
|
ok, nevermind, the changes I requested are actually done on #750 it's confusing that the PR show those changes, but it's probably related to the PR having conflicts |
NiklasMerz
force-pushed
the
feat/bump-major
branch
from
7db3001 to
52daaa2
Compare
jcesarmobile
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
None
Motivation and Context
Preparing for next major release that will be for Cordova-Android's next major.
Description
Bump package and package-lock to 6.0.0-dev
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))