fix(android): return error if file url is null #632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
android
Motivation and Context
When picking files from the gallery, sometimes it can return "null" as the path, but on the success callback.
This PR will call the error callback if the file path is null (might be breaking if people is expecting null result for some reason?)
The PR also unify the logic, since at the moment this code returns a file url
but this code returns a content url
The PR will try to return a file url if available, and if not available, the content url. (and the error if none is available)
So, some cases where the url was null, won't be anymore.
closes #368 as it will return a file url if available
Description
note: use the "Hide whitespace changes" github option for easier review, the code changes are very small
Testing
tested on real android devices with the code provided
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)