Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-11661: (ios) Add mandatory iOS 10 privacy description #236

Closed
wants to merge 1 commit into from
Closed

CB-11661: (ios) Add mandatory iOS 10 privacy description #236

wants to merge 1 commit into from

Conversation

jacquesdev
Copy link
Contributor

@jacquesdev jacquesdev commented Sep 5, 2016

Platforms affected

iOS

What does this PR do?

Ensures the plugin enables users to select photos from the photoalbum in iOS10.

What testing has been done on this change?

It was a bug in my app before, and after this change, I am now able to successfully add photos to the photoalbum

Checklist

  • ICLA has been signed and submitted to [email protected].
  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Add support for photoalbum description

@jcesarmobile
Copy link
Member

Hi.

The camera plugin is using jsdoc2md to create the README.md, so you have to also edit jsdoc2md/TEMPLATE.md (we missed it on the previous PR)

You can see the commit that fixed the error
9fe9447

@jacquesdev
Copy link
Contributor Author

jacquesdev commented Sep 5, 2016

Ok will update that now.

Now updated.

Add support for photoalbum description
@kristiyandobrev
Copy link

By the way if trying to shoot a video on iOS it crashes because it needs a permission for the Microphone or NSMicrophoneUsageDescription in the plist 😤

@jcesarmobile
Copy link
Member

jcesarmobile commented Sep 5, 2016

Right, I missed that permission, can you create a new issue for that? http://issues.cordova.io

@cordova-qa
Copy link

Cordova CI Build has one or more failures.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Link Link Link

@jcesarmobile
Copy link
Member

Let there be tests

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Link Link Link

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Link Link Link

@jacquesdev
Copy link
Contributor Author

@jcesarmobile - please let me know if you need anything else from me to get this merged.

@asfgit asfgit closed this in 9b566d3 Sep 6, 2016
@jcesarmobile
Copy link
Member

Everything was fine, just didn't have time to merge it yesterday.
Merged now, thanks for the PR

@jcesarmobile
Copy link
Member

@kristiyandobrev I created an issue for the video problem , but I can't really reproduce it, camera plugin doesn't allow to record videos, only use existing videos from the device library. Where you using the camera plugin when you had the crash because of the NSMicrophoneUsageDescription? In that case, can you comment on the issue and provide your code?

@kristiyandobrev
Copy link

kristiyandobrev commented Sep 8, 2016

Sorry @jcesarmobile my bad. It's actually Cordova Media Capture Plugin not the camera one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants