-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-11661: (ios) Add mandatory iOS 10 privacy description #236
Conversation
Hi. The camera plugin is using jsdoc2md to create the README.md, so you have to also edit jsdoc2md/TEMPLATE.md (we missed it on the previous PR) You can see the commit that fixed the error |
Ok will update that now. Now updated. |
Add support for photoalbum description
By the way if trying to shoot a video on |
Right, I missed that permission, can you create a new issue for that? http://issues.cordova.io |
Let there be tests |
@jcesarmobile - please let me know if you need anything else from me to get this merged. |
Everything was fine, just didn't have time to merge it yesterday. |
@kristiyandobrev I created an issue for the video problem , but I can't really reproduce it, camera plugin doesn't allow to record videos, only use existing videos from the device library. Where you using the camera plugin when you had the crash because of the |
Sorry @jcesarmobile my bad. It's actually Cordova Media Capture Plugin not the camera one. |
Platforms affected
iOS
What does this PR do?
Ensures the plugin enables users to select photos from the photoalbum in iOS10.
What testing has been done on this change?
It was a bug in my app before, and after this change, I am now able to successfully add photos to the photoalbum
Checklist
Add support for photoalbum description