Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch travis ci for github actions #96

Merged
merged 4 commits into from
Apr 9, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 3, 2020

  • Drop Travis CI
  • Add GitHub Actions
  • Add package-lock.json to use npm cit
  • Add nyc code coverage dependency
  • Send coverage report to codecov service
  • Update README CI badge to GitHub Actions

Overall goal, unify services used across repo. Travis CI is a slow service during peak hours and its something that is unbearable. This is caused by the resources of the service is shared across all Apache projects. If people have limited time to review and/or do releases, waiting for tests should not be a bottleneck.

@erisu erisu added this to the 3.0 milestone Apr 3, 2020
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally agree that Github actions is more convenient than Travis which can be slow and time out.

Code looks good to me,too. Do we want to add package-lock.json to Git with this PR? Is this intentional? I still don't know if adding package-lock is a good idea for librariees like this one.

@erisu
Copy link
Member Author

erisu commented Apr 3, 2020

Per NPMJS:

It is highly recommended you commit the generated package lock to source control

Anyone using this library should install it though npm install xcode which does not use the package-lock.json as it is never bundled with the package.

@NiklasMerz
Copy link
Member

* Commit `package-lock.json` PR: [apache/cordova#4](https://github.com/apache/cordova/issues/4)

Per NPMJS:

It is highly recommended you commit the generated package lock to source control

Anyone using this library should install it though npm install xcode which does not use the package-lock.json as it is never bundled with the package.

Thank you. I learned something new!

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too

@timbru31
Copy link
Member

timbru31 commented Apr 3, 2020

@NiklasMerz - FYI: apache/cordova#4

@erisu erisu modified the milestones: 3.0, 4.0 Apr 6, 2020
@erisu erisu merged commit 9fb83bb into apache:master Apr 9, 2020
@erisu erisu deleted the ci/github-actions branch April 9, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants