Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(npm): bump dependencies #94

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 2, 2020

Bump Dependencies to Latest

  • simple-plist@^1.1.0
  • uuid@^7.0.3

* simple-plist@^1.1.0
* uuid@^7.0.3
@erisu erisu added this to the 3.0 milestone Apr 2, 2020
@erisu erisu requested a review from timbru31 April 2, 2020 07:43
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So one could with v3 of the lib:

const uuid = require('uuid');
uuid()

But we do

const uuid = require('uuid');
uuid.v4()

so we should be fine

@erisu erisu merged commit dc678cc into apache:master Apr 2, 2020
@erisu erisu deleted the breaking/bump-dependencies branch April 2, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants