Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(travis): removes Node.js v6 and v8 from testing #90

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Mar 28, 2020

@timbru31 timbru31 changed the title ci(travis): removes Node.js v6 and v8 from testing WIP: ci(travis): removes Node.js v6 and v8 from testing Mar 28, 2020
.travis.yml Show resolved Hide resolved
Copy link

@brodycj brodycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would strongly favor combining this with #92.

@timbru31
Copy link
Member Author

Combining as in one PR or merge quickly after another? I'd vote for the second approach - keep different changes in different PR's with different commit messages. This helps us to revert any potential wrong changes more cleanly and easily.

@timbru31 timbru31 changed the title WIP: ci(travis): removes Node.js v6 and v8 from testing ci(travis): removes Node.js v6 and v8 from testing Mar 30, 2020
@timbru31 timbru31 merged commit 2d043a2 into master Mar 30, 2020
@timbru31 timbru31 deleted the feat/updates-node-in-ci branch March 30, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants