Build of app_extension target is not covered by test suite

[brody4hire]

The following changes would not be detected by the existing test suite:

1:

diff --git a/lib/pbxProject.js b/lib/pbxProject.js
index 0e0f8f9..5894d91 100644
--- a/lib/pbxProject.js
+++ b/lib/pbxProject.js
@@ -1466,19 +1466,6 @@ pbxProject.prototype.addTarget = function(name, type, subfolder) {
     // Target: Add to PBXNativeTarget section
     this.addToPbxNativeTargetSection(target)
 
-    // Product: Embed (only for "extension"-type targets)
-    if (targetType === 'app_extension') {
-
-        // Create CopyFiles phase in first target
-        this.addBuildPhase([], 'PBXCopyFilesBuildPhase', 'Copy Files', this.getFirstTarget().uuid,  targetType)
-
-        // Add product to CopyFiles phase
-        this.addToPbxCopyfilesBuildPhase(productFile)
-
-       // this.addBuildPhaseToTarget(newPhase.buildPhase, this.getFirstTarget().uuid)
-
-    };
-
     // Target: Add uuid to root project
     this.addToPbxProjectSection(target);
 

2:

diff --git a/lib/pbxProject.js b/lib/pbxProject.js
index 0e0f8f9..d7e65da 100644
--- a/lib/pbxProject.js
+++ b/lib/pbxProject.js
@@ -1555,7 +1555,7 @@ function pbxCopyFilesBuildPhaseObj(obj, folderType, subfolderPath, phaseName) {
      // Add additional properties for 'CopyFiles' build phase
     var DESTINATION_BY_TARGETTYPE = {
         application: 'wrapper',
-        app_extension: 'plugins',
+        app_extension: '',
         bundle: 'wrapper',
         command_line_tool: 'wrapper',
         dynamic_library: 'products_directory',

3:

diff --git a/lib/pbxProject.js b/lib/pbxProject.js
index 0e0f8f9..7301a16 100644
--- a/lib/pbxProject.js
+++ b/lib/pbxProject.js
@@ -1555,7 +1555,6 @@ function pbxCopyFilesBuildPhaseObj(obj, folderType, subfolderPath, phaseName) {
      // Add additional properties for 'CopyFiles' build phase
     var DESTINATION_BY_TARGETTYPE = {
         application: 'wrapper',
-        app_extension: 'plugins',
         bundle: 'wrapper',
         command_line_tool: 'wrapper',
         dynamic_library: 'products_directory',

I think the test coverage is needed to help ensure the functionality would not be broken by future changes.

Detected through mutation testing (PR #61) of watchkit2 updates (PR #56).

[l3ender]

I believe I've covered this in #66, but I haven't finished running Stryker on it yet.

[brody4hire]

I believe I've covered this in #66, but I haven't finished running Stryker on it yet.

Thanks again @l3ender for your help.

You can see in PR #66 that I did already check by hand that it does cover the possible changes discussed here.

I wouldn't worry too much about finishing the run on Stryker at this point. As I said in PR #63, Stryker takes a really, really long time if we don't use something like 16 CPUs worth of computing power.