Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump eslint w/ lint fix & rebuilt package-lock #869

Merged
merged 1 commit into from
May 27, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 27, 2020

Motivation, Context & Description

  • Use our latest version of ESlint config dev dependency.
  • Apply lint corrections
  • Include a rebuilt package-lock.json

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone May 27, 2020
@erisu erisu requested review from timbru31 and NiklasMerz May 27, 2020 06:09
@erisu erisu changed the title refactor: bump eslint w/ applied lint fix & rebuilt package-lock.json refactor: bump eslint w/ lint fix & rebuilt package-lock May 27, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #869 into master will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #869   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files          13       13           
  Lines        1676     1676           
=======================================
  Hits         1248     1248           
  Misses        428      428           
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 71.53% <0.00%> (ø)
bin/templates/scripts/cordova/lib/prepare.js 85.67% <82.60%> (ø)
bin/templates/scripts/cordova/lib/Podfile.js 73.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094f826...dfc9f66. Read the comment docs.

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@erisu erisu merged commit 37338bf into apache:master May 27, 2020
@erisu erisu deleted the refactor/eslint-bump branch May 27, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants