breaking: remove deprecated orientation methods #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
approved these changes
Apr 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
=======================================
Coverage 74.20% 74.20%
=======================================
Files 13 13
Lines 1849 1849
=======================================
Hits 1372 1372
Misses 477 477 Continue to review full report at Codecov.
|
timbru31
approved these changes
Apr 5, 2020
jcesarmobile
changed the title
|
I've changed the title to "breaking" as it will break plugins using the orientation delegate, not sure how many are using it. Since it's already merged and the breaking wasn't included in the commit I hope we don't forget about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- (NSUInteger)application:(UIApplication*)application supportedInterfaceOrientationsForWindow:(UIWindow*)window,- (NSUInteger)supportedInterfaceOrientations;and- (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientationwere deprecated on iOS 6, remove the code as is not being used.I think it's not breaking since we have the new methods that replaced them.
closes #821