Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: applied various xcode recommended update #802

Merged
merged 2 commits into from
Feb 29, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 29, 2020

Motivation and Context

Continue to remove warnings and bringing the repo up-to-date

Description

  • Perform Xcode recommended update
  • Migrate localization
  • Enable Base Internationalization

Changes are primarily directed to CordovaLibTests but as the project is loaded though cordova-ios.xcworkspace, Xcode also cleaned up one area in CordovaLib. Those changes are safe to be applied with this PR.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone Feb 29, 2020
@erisu erisu requested a review from dpogue February 29, 2020 05:35
@erisu erisu merged commit bfc463c into apache:master Feb 29, 2020
@erisu erisu deleted the test/update-cordovalibtest branch February 29, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants