Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove extra space from Objective-C test modules #794

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

brodycj
Copy link

@brodycj brodycj commented Feb 18, 2020

No description provided.

@brodycj brodycj added the bug label Feb 18, 2020
@erisu erisu added enhancement and removed bug labels Feb 19, 2020
@erisu erisu changed the title cleanup: remove extra space from Objective-C test modules style: remove extra space from Objective-C test modules Feb 19, 2020
@brodycj brodycj merged commit 4ac1552 into apache:master Feb 19, 2020
@brodycj brodycj deleted the objc-tests-lib-remove-whitespace branch February 19, 2020 01:02
@erisu
Copy link
Member

erisu commented Feb 19, 2020

LGTM.

Sorry I made some changes to the PR entry.

I don't find this as a bug as it does not break tests or built apps in anyway. It is more of a styling change and per available tags, enhancement IMO fits best.

Also for title, though it can be debated, I changed it to style since it is shorter and fits the type of changes.

I been using recently these as my own personal guide but slightly modified. We don't really have a hard requirement on this format and is more a freely to use I guess.

https://karma-runner.github.io/1.0/dev/git-commit-msg.html
https://www.conventionalcommits.org/en/v1.0.0/

@brodycj
Copy link
Author

brodycj commented Feb 19, 2020

Thanks @erisu, you should see that I just did a quick merge. I actually noticed the title update after the merge, cool 😎(I generally like to do this kind of change as fast as possible, I was in the middle of testing for something else.)

I been using recently these as a guide but slightly modified.

+1, nice; I wouldn't mind if we would discuss these somewhere other than a closed PR :)

NiklasMerz pushed a commit to GEDYSIntraWare/cordova-ios that referenced this pull request Feb 24, 2020
* remove trailing whitespace from tests/CordovaLibTests/*.m

* remove extra blank lines from tests/CordovaLibTests/CDVWhitelistTests.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants