chore(ci): Fix ObjC testing with latest Xcode #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
=======================================
Coverage 78.50% 78.50%
=======================================
Files 16 16
Lines 1814 1814
=======================================
Hits 1424 1424
Misses 390 390 ☔ View full report in Codecov by Sentry. |
ishiguro-m-wing
added a commit
to dejiren/cordova-ios
that referenced
this pull request
Mar 29, 2024
This reverts commit 1974dbb. Revert "feat: add privacy-manifest config support (apache#1406)" This reverts commit c97845a. Revert "ci(gh-action): add Apache RAT & package license checker workflow w/ license header additions (apache#1408)" This reverts commit d316558. Revert "fix: use PROVISIONING_PROFILE_SPECIFIER for manual codesigning (apache#1405)" This reverts commit af6335e. Revert "feat: add PrivacyInfo.xcprivacy for CordovaLib & app template (apache#1383)" This reverts commit b400b70. Revert "fix: WASM MIME type error by specifying it in Info.plist template (apache#1374)" This reverts commit 902df96. Revert "chore: update package & package-lock (apache#1404)" This reverts commit 2091208. Revert "chore: bump 7.1.0-dev for next minor release (apache#1403)" This reverts commit 766adcf. Revert "chore(deps-dev): bump @babel/traverse from 7.21.4 to 7.23.2 (apache#1382)" This reverts commit 92017bb. Revert "chore: Update Slack signup link in SUPPORT_QUESTION.md (apache#1380)" This reverts commit be4c884. Revert "chore: bump version 7.0.2-dev" This reverts commit a1f3ace.
ishiguro-m-wing
pushed a commit
to dejiren/cordova-ios
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Tests would fail to run in Xcode 15 due to not having a iPhone 8 simulator with the latest runtime, and
CONFIGURATION_BUILD_DIRwas causing errors about Cordova.framework not being found and sometimes warnings about stale files.Description
AppDelegate*-derivedDataPathrather thanCONFIGURATION_BUILD_DIRso that Apple doesn't cache stale data about previous runsTesting
Ran in GitHub CI and locally with latest Xcode 15
Checklist