fix: Xcode 15 Beta #1336
Merged
fix: Xcode 15 Beta #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once upon a time, Xcode was eagerly telling me to change everything to use @import... and now it's giving me errors saying that's absolutely not allowed in framework headers. So we'll go back to the #import way of doing things (until Xcode complains about it again in some future version)
Remove it from the list of excluded files, since I'm pretty sure this doesn't get generated and put here anymore.
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
=======================================
Coverage 78.62% 78.62%
=======================================
Files 15 15
Lines 1801 1801
=======================================
Hits 1416 1416
Misses 385 385 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
erisu
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Resolve some errors/warnings from the latest Xcode beta.
Description
Testing
Project compiles with no unexpected warnings (just the expected one about targeting iOS 11)
Checklist