Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: simpler killing of running simulators #1179

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

Slim down code base

Description

This replaces a JS script that should kill any running simulators by a simple shell command

Testing

  • I verified that the killall command does nothing if no simulator is running
  • It would be great if someone verified that this actually kills a running simulator

@codecov-commenter
Copy link

Codecov Report

Merging #1179 (8dc9228) into master (b0d7099) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1179   +/-   ##
=======================================
  Coverage   74.95%   74.95%           
=======================================
  Files          14       14           
  Lines        1705     1705           
=======================================
  Hits         1278     1278           
  Misses        427      427           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d7099...8dc9228. Read the comment docs.

@erisu erisu merged commit 593bbbd into apache:master Nov 4, 2021
@raphinesse raphinesse deleted the simpler-killall branch November 6, 2021 21:09
@erisu erisu added this to the 7.0.0 milestone Nov 16, 2021
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants