Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1059: Add VALIDATE_WORKSPACE setting to XcodeProj #1060

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jan 19, 2021

Platforms affected

iOS

Motivation and Context

Closes GH-1059

Description

In Xcode 12, if an app is linked against .framework files with multiple architectures, it will generate an error about embedded framework mismatches. Declaring this property (even with its default value of NO) resolves the issue.

Testing

CI passing

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

In Xcode 12, if an app is linked against .framework files with multiple
architectures, it will generate and error about embedded framework
mismatches. Declaring this property (even with its default value of NO)
resolves the issue.
@dpogue dpogue marked this pull request as ready for review January 19, 2021 16:27
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@wilsolutions wilsolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the issue.

@dpogue dpogue added this to the 6.next milestone Jan 19, 2021
@dpogue dpogue merged commit fb999cb into apache:master Jan 19, 2021
@dpogue dpogue deleted the validate-workspace branch January 19, 2021 19:56
@JoeMeeks
Copy link

@dpogue can the yes/no or true/false value of VALIDATE_WORKSPACE be assigned in config.xml?

@dpogue
Copy link
Member Author

dpogue commented Aug 26, 2021

can the yes/no or true/false value of VALIDATE_WORKSPACE be assigned in config.xml?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building for iOS Simulator error when not using .xcframework
4 participants