CB-14135(ios): escape all single quotes from name in Podfile (#731)

apache · Dec 2, 2019 · c1a6640 · c1a6640
1 parent a5a009c
commit c1a6640
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/bin/templates/scripts/cordova/lib/Podfile.js b/bin/templates/scripts/cordova/lib/Podfile.js
@@ -168,7 +168,7 @@ Podfile.prototype.__parseForPods = function (text) {
 };
 
 Podfile.prototype.escapeSingleQuotes = function (string) {
-    return string.replace('\'', '\\\'');
+    return string.replace(/'/g, '\\\'');
 };
 
 Podfile.prototype.getTemplate = function () {

diff --git a/tests/spec/unit/Podfile.spec.js b/tests/spec/unit/Podfile.spec.js
@@ -153,9 +153,20 @@ describe('unit tests for Podfile module', function () {
             expect(actualProjectName).toBe(expectedProjectName);
         });
 
+        it('Test 011 : escapes double single quotes in project name when writing a Podfile', function () {
+            podfile.before_install();
+
+            var projectName = 'l\'etat c\'est moi';
+
+            var expectedProjectName = 'l\\\'etat c\\\'est moi';
+            var actualProjectName = podfile.escapeSingleQuotes(projectName);
+
+            expect(actualProjectName).toBe(expectedProjectName);
+        });
+
     });
 
-    it('Test 011 : tear down', function () {
+    it('Test 012 : tear down', function () {
         podfile.destroy();
 
         var text = '// DO NOT MODIFY -- auto-generated by Apache Cordova\n';