Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop node 6 and 8 support #69

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 30, 2019

Motivation and Context

Next major release, [email protected] will no longer test or require code to be backwards compatible with node 6 and 8.

Description

  • Removes node 6 and 8 from testing and package.json.
  • Updated minimum supported node and npm version.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 3.0.0 milestone Oct 30, 2019
@erisu erisu requested a review from raphinesse October 30, 2019 02:09
@erisu erisu force-pushed the v3-drop-old-node-support branch from 95580f7 to 914f575 Compare October 30, 2019 08:50
@erisu erisu force-pushed the v3-drop-old-node-support branch from 914f575 to 13ea95c Compare October 31, 2019 02:47
Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after #68

@erisu erisu merged commit a15608c into apache:master Oct 31, 2019
@erisu erisu deleted the v3-drop-old-node-support branch October 31, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants