Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.apache.commons:commons-parent from 78 to 79, fix changes.xml format for new plugin version #298

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Comment on lines 782 to 783
<!-- <dueto name="Cott"/>-->
<!-- <dueto name="Gabriel Belingueres"/>-->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dueto to attribute

@@ -825,7 +825,7 @@ http://commons.apache.org/validator/dependencies.html
<action dev="niallp" type="fix" issue="VALIDATOR-60" due-to="Yugandhar">
Change JavaScript validators to cater for disabled being undefined (an issue in Netscape 4.7).
</action>
<action dev="niallp" type="add">
<action dev="niallp" type="add"><![CDATA[
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

action body can not contains more tags ...

@@ -873,19 +871,15 @@ http://commons.apache.org/validator/dependencies.html
Resolve issue in JavaScript validation when the prototype library
is used.
</action>
<action dev="niallp" type="fix">
<action dev="niallp" type="fix" fixedIssues="VALIDATOR-97, VALIDATOR-81" due-to="Matt Bathje, Paul Benedict">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 there is a bug in m-changes-p arrtibute name should be fixed-issues

Comment on lines 1044 to 1054

<release version="1.1.2 (alpha)" date="2004-04-03" description="1.1 Alpha">
<action dev="rleland" type="fix" issue="VALIDATOR-24">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed only for testing purpose - to fix

@sebbASF
Copy link
Contributor

sebbASF commented Dec 28, 2024

Please use separate PRs for each independent change so they can be separately evaluated

@sebbASF sebbASF closed this Dec 28, 2024
@garydgregory
Copy link
Member

@sebbASF
All these changes must be done at once, @slawekjaranowski and I are working to get Doxia 2 from the commons-skin to the commons-parent down to components. This PR can be reopened as a draft.

@garydgregory garydgregory reopened this Dec 28, 2024
@sebbASF
Copy link
Contributor

sebbASF commented Dec 29, 2024

It would help if the title and description bore some relation to the purpose of the PR

@slawekjaranowski slawekjaranowski changed the title Test parent 79 Bump org.apache.commons:commons-parent from 78 to 79, fix changes.xml format for new plugin version Dec 30, 2024
@slawekjaranowski
Copy link
Member Author

@sebbASF @garydgregory updated ... should be ok after parent 79 will be released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants