Normalize equals() implementation

apache · Sep 27, 2023 · 8b9c16e · 8b9c16e
1 parent 37c292f
commit 8b9c16e
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/main/java/org/apache/commons/validator/util/Flags.java b/src/main/java/org/apache/commons/validator/util/Flags.java
@@ -159,17 +159,14 @@ public Object clone() {
      */
     @Override
     public boolean equals(final Object obj) {
+        if (this == obj) {
+            return true;
+        }
         if (!(obj instanceof Flags)) {
             return false;
         }
-
-        if (obj == this) {
-            return true;
-        }
-
-        final Flags f = (Flags) obj;
-
-        return this.flags == f.flags;
+        Flags other = (Flags) obj;
+        return flags == other.flags;
     }
 
     /**