Addressing the findings from the review

apache · Jan 2, 2025 · 4195ee7 · 4195ee7
1 parent d18cb91
commit 4195ee7
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/org/apache/commons/validator/UrlValidator.java b/src/main/java/org/apache/commons/validator/UrlValidator.java
@@ -138,7 +138,7 @@ public class UrlValidator implements Serializable {
     private static final int PARSE_URL_FRAGMENT = 9;
 
     /**
-     * Protocol (that is, http:, ftp:, https:).
+     * Protocol (for example, http:, ftp:, https:).
      */
     private static final Pattern SCHEME_PATTERN = Pattern.compile("^\\p{Alpha}[\\p{Alnum}\\+\\-\\.]*");
 

diff --git a/src/main/java/org/apache/commons/validator/routines/CodeValidator.java b/src/main/java/org/apache/commons/validator/routines/CodeValidator.java
@@ -61,7 +61,7 @@
  * Codes often include <em>format</em> characters - such as hyphens - to make them
  * more easily human-readable. These can be removed prior to length and check digit
  * validation by specifying them as a <em>non-capturing</em> group in the regular
- * expression (for example, use the {@code (?:   )} notation).
+ * expression (that is, use the {@code (?:   )} notation).
  * <br>
  * Or just avoid using parentheses except for the parts you want to capture
  *

diff --git a/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java b/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
@@ -474,7 +474,7 @@ public CreditCardValidator(final long options) {
 
     /**
      * Tests whether the given flag is on. If the flag is not a power of 2
-     * (that is, 3) this tests whether the combination of flags is on.
+     * (for example, 3) this tests whether the combination of flags is on.
      *
      * @param options The options specified.
      * @param flag Flag value to check.

diff --git a/src/main/java/org/apache/commons/validator/routines/UrlValidator.java b/src/main/java/org/apache/commons/validator/routines/UrlValidator.java
@@ -325,7 +325,7 @@ protected int countToken(final String token, final String target) {
 
     /**
      * Tests whether the given flag is off.  If the flag is not a power of 2
-     * (that is, 3) this tests whether the combination of flags is off.
+     * (for example, 3) this tests whether the combination of flags is off.
      *
      * @param flag Flag value to check.
      * @return whether the specified flag value is off.
@@ -336,7 +336,7 @@ private boolean isOff(final long flag) {
 
     /**
      * Tests whether the given flag is on.  If the flag is not a power of 2
-     * (that is, 3) this tests whether the combination of flags is on.
+     * (for example, 3) this tests whether the combination of flags is on.
      *
      * @param flag Flag value to check.
      * @return whether the specified flag value is on.

diff --git a/src/main/java/org/apache/commons/validator/routines/package-info.java b/src/main/java/org/apache/commons/validator/routines/package-info.java
@@ -385,7 +385,7 @@
  * <li><a href="#other.regex">Regular Expressions</a> - validates
  * using Java 1.4+ regular expression support</li>
  * <li><a href="#other.checkdigit">Check Digit</a> - validates/calculates
- * check digits (that is, EAN/UPC, credit card, ISBN).</li>
+ * check digits (for example, EAN/UPC, credit card, ISBN).</li>
  * <li><a href="#other.code">Code Validation</a> - provides generic
  * code validation - format, minimum/maximum length and check digit.</li>
  * <li><a href="#other.iban">IBAN Validation</a> - provides International Bank Account Number validation.</li>