Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPRESS-550 : add writePreamble to ZipArchiveInputStream #127

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

PeterAlfredLee
Copy link
Member

Add writePreamble to ZipArchiveInputStream. This is used to create self-extracting zip.

@coveralls
Copy link

coveralls commented Aug 18, 2020

Coverage Status

Coverage decreased (-0.009%) to 87.238% when pulling 2f61221 on PeterAlfredLee:COMPRESS-550 into 4ede294 on apache:master.

@garydgregory
Copy link
Member

@dependabot rebase

@XenoAmess
Copy link
Contributor

@dependabot rebase

@PeterAlfredLee 👍

Add writePreamble to ZipArchiveInputStream. This is used to create
self-extracting zips.
@PeterAlfredLee
Copy link
Member Author

Hi all. I'm merging this PR these days. WDYT? @garydgregory @bodewig

@garydgregory
Copy link
Member

@PeterAlfredLee I don't know enough about zip and preambles to really opine.

@PeterAlfredLee PeterAlfredLee merged commit a40c53d into apache:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants