server: fix duplicated records for templates if there are multiple zones

[weizhouapache]

Description

This PR fixes #8928

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

This fixes a bug in #7659
cc @BryanMLima

[BryanMLima]

CLGTM, I will try to manually test this today.

[DaanHoogland]

clgtm

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9297

[weizhouapache]

@blueorangutan test rocky8 kvm-rocky8

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

[sureshanaparti]

clgtm

[blueorangutan]

[SF] Trillian test result (tid-9887)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 46469 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8933-t9887-kvm-rocky8.zip
Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	299.22	test_events_resource.py
test_01_events_resource	Error	299.23	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Failure	90.14	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	Error	1.49	test_network_permissions.py
test_02_list_cpvm_vm	Failure	0.05	test_ssvm.py
test_04_cpvm_internals	Failure	0.05	test_ssvm.py

[BryanMLima]

I manually tested this patch in a local lab, working as intended.

Before two records were created:

After applying the patch, only one record was created:

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9360

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9951)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51237 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8933-t9951-kvm-centos7.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	290.88	test_events_resource.py
test_01_events_resource	Error	290.89	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Failure	87.79	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	Error	1.40	test_network_permissions.py