Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non admin logouts #8065

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fix non admin logouts #8065

merged 2 commits into from
Oct 11, 2023

Conversation

harikrishna-patnala
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala commented Oct 10, 2023 •
edited
Loading

Description

If a user (non-admin) logs out from a session, then login page is not loading completely. Few starter APIs like listIds are failing and showing unauthorised access notification in Login Page. Also if SAML is enabled, it is not getting enabled since the corresponding API are failed. User needs to refresh the browser to get it back.

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Login and logout with non admin users and you dont see any errors in the login page and all applicable login options will be enabled
image

How did you try to break this feature and the system with this change?

@harikrishna-patnala harikrishna-patnala changed the base branch from main to 4.18 October 10, 2023 09:08
@DaanHoogland DaanHoogland added this to the 4.18.2.0 milestone Oct 10, 2023
DaanHoogland
DaanHoogland approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #8065 (2c62676) into 4.18 (29c7b31) will increase coverage by 0.05%.
Report is 71 commits behind head on 4.18.
The diff coverage is 18.30%.

@@             Coverage Diff              @@
##               4.18    #8065      +/-   ##
============================================
+ Coverage     13.02%   13.07%   +0.05%     
- Complexity     9032     9111      +79     
============================================
  Files          2720     2720              
  Lines        257080   257537     +457     
  Branches      40088    40156      +68     
============================================
+ Hits          33476    33669     +193     
- Misses       219400   219637     +237     
- Partials       4204     4231      +27
Files Coverage Δ
...hestration/service/VolumeOrchestrationService.java 100.00% <ø> (ø)
.../main/java/com/cloud/network/IpAddressManager.java 100.00% <100.00%> (ø)
...ava/com/cloud/network/as/AutoScaleVmProfileVO.java 80.20% <100.00%> (+11.66%) ⬆️
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java 40.89% <100.00%> (+0.64%) ⬆️
...va/com/cloud/upgrade/DatabaseVersionHierarchy.java 85.10% <100.00%> (+1.01%) ⬆️
.../api/command/admin/ratelimit/ResetApiLimitCmd.java 0.00% <ø> (ø)
...oud/hypervisor/kvm/resource/LibvirtConnection.java 0.00% <ø> (ø)
.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java 10.44% <100.00%> (ø)
...ava/com/cloud/api/commands/StopNetScalerVMCmd.java 0.00% <ø> (ø)
...tungsten/api/command/ListTungstenFabricTagCmd.java 0.00% <ø> (ø)
... and 58 more

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rohityadavcloud
Copy link
Member

Didn't test it but LGTM

@rohityadavcloud
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8065 (QA-JID-198)

BryanMLima
BryanMLima approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@BryanMLima BryanMLima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manually tested this with a user type account.

Screenshot from 2023-10-10 16-51-38

ui/src/views/dashboard/UsageDashboard.vue Outdated Show resolved Hide resolved
@DaanHoogland DaanHoogland reopened this Oct 11, 2023
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7323

@DaanHoogland
Copy link
Contributor

@blueorangutan LLtest

@blueorangutan
Copy link

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@rohityadavcloud
Copy link
Member

Since this is strictly UI only change smoketest wasn't required @DaanHoogland

@rohityadavcloud rohityadavcloud merged commit 8b28128 into apache:4.18 Oct 11, 2023
49 of 51 checks passed
@rohityadavcloud rohityadavcloud deleted the FixNonAdminLogouts branch October 11, 2023 11:28
@blueorangutan
Copy link

[LL]Trillian test result (tid-6824)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46025 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8065-t6824-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_vm_wrong_checksum Error 41.25 test_templates.py
test_09_list_templates_download_details Failure 0.05 test_templates.py

rp- pushed a commit to LINBIT/cloudstack that referenced this pull request Oct 13, 2023
@harikrishna-patnala @rp-
ui: Fix non admin logouts (apache#8065)
fb2a5b8 
If a user (non-admin) logs out from a session, then login page is not loading completely. Few starter APIs like listIds are failing and showing unauthorised access notification in Login Page. Also if SAML is enabled, it is not getting enabled since the corresponding API are failed. User needs to refresh the browser to get it back.
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Nov 3, 2023
@harikrishna-patnala @rohityadavcloud
ui: Fix non admin logouts (apache#8065)
84fee7b 
If a user (non-admin) logs out from a session, then login page is not loading completely. Few starter APIs like listIds are failing and showing unauthorised access notification in Login Page. Also if SAML is enabled, it is not getting enabled since the corresponding API are failed. User needs to refresh the browser to get it back.

(cherry picked from commit 8b28128)
Signed-off-by: Rohit Yadav <[email protected]>
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request Mar 31, 2024
@harikrishna-patnala @rohityadavcloud
ui: Fix non admin logouts (apache#8065)
4655b5d 
If a user (non-admin) logs out from a session, then login page is not loading completely. Few starter APIs like listIds are failing and showing unauthorised access notification in Login Page. Also if SAML is enabled, it is not getting enabled since the corresponding API are failed. User needs to refresh the browser to get it back.

(cherry picked from commit 8b28128)
Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanMLima BryanMLima BryanMLima approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees
No one assigned
Labels
component:api component:build component:networking component:UI
Projects
None yet
Milestone
4.18.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@harikrishna-patnala @rohityadavcloud @blueorangutan @DaanHoogland @BryanMLima