Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VR: Do not add iptables rules for the revoked ip addresses #6189

Merged

Conversation

weizhouapache
Copy link
Member

Description

This PR removes the rules for the ip addresses which are not used.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3043

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3790)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32388 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6189-t3790-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez merged commit c61ea9f into apache:4.16 Apr 6, 2022
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache weizhouapache deleted the 4.16-vr-no-rules-for-revoked-ip-address branch December 9, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants