Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List virtual machines with details=min,nics #60

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

weizhouapache
Copy link
Member

This should fix apache/cloudstack#8975

@weizhouapache
Copy link
Member Author

did a quick testing, it looks ok

the API command is
2024-04-26T08:20:25,740 DEBUG [c.c.a.ApiServlet] (qtp1375394559-21:[ctx-8dc8b523]) (logid:10e8a469) ===START=== 10.0.53.169 -- GET apiKey=FbdMHXgGot3JuiEmoldLwOo3ZWh4fGjSDTsLz5qXDZn05Q7CSh4ZXSFVJfNYUwWct5YBwHlLZKFVLR-NFKnLkw&command=listVirtualMachines&details=min%2Cnics&listall=true&response=json&signature=K3US18HTxZvG2pJ29nnP8N3PYRg%3D

the parameter (details=min%2Cnics) is set as expected

@weizhouapache weizhouapache marked this pull request as ready for review April 26, 2024 13:14
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@rohityadavcloud rohityadavcloud merged commit 910f558 into main May 20, 2024
2 checks passed
@rohityadavcloud rohityadavcloud deleted the list-vm-details branch May 20, 2024 07:13
hrak added a commit to leaseweb/cloudstack-kubernetes-provider that referenced this pull request May 27, 2024
hrak added a commit to leaseweb/cloudstack-kubernetes-provider that referenced this pull request May 27, 2024
hrak added a commit to leaseweb/cloudstack-kubernetes-provider that referenced this pull request May 27, 2024
hrak added a commit to leaseweb/cloudstack-kubernetes-provider that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When deploying node to Kubernetes it times out
3 participants