Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple local storage pools in KVM - via UI #366

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Add multiple local storage pools in KVM - via UI #366

merged 8 commits into from
Jan 17, 2024

Conversation

andrijapanicsb
Copy link
Contributor

@andrijapanicsb andrijapanicsb commented Dec 11, 2023 •
edited by github-actions bot
Loading

Add additional local storage for KVM - via UI.

📚 Documentation preview 📚: https://cloudstack-documentation--366.org.readthedocs.build/en/366/

@andrijapanicsb andrijapanicsb changed the title Update storage.rst Add multiple local storage pools in KVM - via UI Dec 11, 2023
@andrijapanicsb
Copy link
Contributor Author

@blueorangutan docbuild

shwstppr
shwstppr approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

weizhouapache
weizhouapache approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@shwstppr shwstppr added this to the 4.19 milestone Dec 15, 2023
@shwstppr
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/366. (QA-JID 180)

@andrijapanicsb
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@andrijapanicsb a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/366. (QA-JID 182)

@andrijapanicsb
Copy link
Contributor Author

That did not work - feel free to fix it as needed (I originally copied the "syntax" from another image that did work)

@shwstppr
image fix
517071e 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
refactor
ed75316 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Merge remote-tracking branch 'apache/main' into andrijapanicsb-add-ne…
5d43448 
…w-local-pool-via-UI
@shwstppr
brain-freeze
4190a69 
Signed-off-by: Abhishek Kumar <[email protected]>
@apache apache deleted a comment from blueorangutan Jan 10, 2024
@apache apache deleted a comment from blueorangutan Jan 10, 2024
@apache apache deleted a comment from blueorangutan Jan 10, 2024
@apache apache deleted a comment from blueorangutan Jan 10, 2024
@shwstppr
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/366. (QA-JID 187)

@shwstppr
Copy link
Contributor

shwstppr commented Jan 10, 2024 •
edited
Loading

Image showing now,

Screenshot from 2024-01-10 12-59-13

@shwstppr shwstppr mentioned this pull request Jan 12, 2024
Merged
@DaanHoogland
Copy link
Contributor

Image showing now,

just checked but I don't see it :
https://cloudstack-documentation--366.org.readthedocs.build/en/366/adminguide/storage.html#using-multiple-local-storages-kvm-only
image

am I looking in the right place?

@shwstppr
Copy link
Contributor

@DaanHoogland can you please BO docbuild?

@DaanHoogland
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/366. (QA-JID 196)

@DaanHoogland
Copy link
Contributor

ok, guess there is a problem with the actions, the docbuild works and shows good.

@DaanHoogland DaanHoogland merged commit aa41770 into main Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhouapache weizhouapache weizhouapache approved these changes

@shwstppr shwstppr shwstppr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.19
Development

Successfully merging this pull request may close these issues.
5 participants
@andrijapanicsb @shwstppr @blueorangutan @DaanHoogland @weizhouapache