Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ssh key path on VMware envs #347

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Update ssh key path on VMware envs #347

merged 3 commits into from
Dec 6, 2023

Conversation

Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Sep 18, 2023 •
edited by github-actions bot
Loading

@weizhouapache
Copy link
Member

@Pearl1594
would be good to use ~cloud/.ssh/id_rsa.cloud

@Pearl1594
Copy link
Contributor Author

@Pearl1594 would be good to use ~cloud/.ssh/id_rsa.cloud

Oh nice, I didn't know this. Thanks! updated.

@Pearl1594
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/347. (QA-JID 130)

@Pearl1594 Pearl1594 force-pushed the fix-sshkey-path-vmware branch from c92b65c to 980c8dd Compare September 18, 2023 20:49
weizhouapache
weizhouapache approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Member

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/347. (QA-JID 131)

@weizhouapache
Copy link
Member

@Pearl1594
I searched id_rsa in the doc and found this

Copy the SSH public key from /var/cloudstack/management/.ssh/id_rsa.pub on the management server

@shwstppr
Copy link
Contributor

@Pearl1594 does this need more changes based on @weizhouapache 's comment?

@shwstppr shwstppr added this to the 4.19 milestone Sep 29, 2023
@rohityadavcloud
Copy link
Member

@blueorangutan docbuild

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@rohityadavcloud
Copy link
Member

@blueorangutan docbuild

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@weizhouapache weizhouapache reopened this Dec 5, 2023
@DaanHoogland DaanHoogland reopened this Dec 5, 2023
@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/347. (QA-JID 173)

@shwstppr shwstppr requested a review from DaanHoogland December 6, 2023 12:25
@DaanHoogland DaanHoogland force-pushed the fix-sshkey-path-vmware branch from 980c8dd to af7bc7a Compare December 6, 2023 14:26
DaanHoogland
DaanHoogland approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DaanHoogland DaanHoogland merged commit 6ea6981 into main Dec 6, 2023
1 check passed
@DaanHoogland DaanHoogland deleted the fix-sshkey-path-vmware branch December 6, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhouapache weizhouapache weizhouapache approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@shwstppr shwstppr shwstppr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.19
Development

Successfully merging this pull request may close these issues.
6 participants
@Pearl1594 @weizhouapache @blueorangutan @shwstppr @rohityadavcloud @DaanHoogland