Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1877] Bump zstd-jni version from 1.5.2-1 to 1.5.7-1 #3114

Closed
wants to merge 1 commit into from

Conversation

SteNicholas
Copy link
Member

What changes were proposed in this pull request?

Bump zstd-jni version from 1.5.2-1 to 1.5.7-1.

Why are the changes needed?

Bump zstd-jni to the latest version.

Backport apache/spark#50057.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No.

@SteNicholas
Copy link
Member Author

Ping @pan3793.

@pan3793
Copy link
Member

pan3793 commented Feb 24, 2025

I suppose the upgrade should have perf improvements for the Celeborn client because the default value of celeborn.client.push.buffer.max.size is 64k

and zstd v1.5.7 release notes say

Enhanced Compression Speed for Small Data Blocks

Note: Celeborn Spark shaded client does not ship the zstd-jni and always uses Spark's built-in zstd-jni, if someone wants to test the perf improvement, he/she should upgrade the Spark's built-in zstd-jni first.

@SteNicholas
Copy link
Member Author

Ping @FMX, @RexXiong.

Copy link
Contributor

@FMX FMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Merged into main(v0.6.0), I'll run some performance tests for this PR.

@FMX FMX closed this in 79b4980 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants